Bug 51604

Summary: Move JavaScriptCore to Sources
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, buildbot, dglazkov, eric, gns, mjs, ossy, robert, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 51606    
Attachments:
Description Flags
Patch eric: review+

Description Adam Barth 2010-12-24 23:48:43 PST
Move JavaScriptCore to Sources
Comment 1 Adam Barth 2010-12-24 23:53:22 PST
Created attachment 77434 [details]
Patch
Comment 2 Adam Barth 2010-12-24 23:54:37 PST
This patch doesn't actually contain the move because that would make the patch file huge.  That means this will show up red on all the EWS bots.

I'm going to hold off landing this patch until folks have plenty of warning.  I just wanted to get it uploaded so folks could look at it and let me know what I screwed up.
Comment 3 WebKit Review Bot 2010-12-25 00:08:04 PST
Attachment 77434 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7243188
Comment 4 Early Warning System Bot 2010-12-25 00:11:46 PST
Attachment 77434 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7200187
Comment 5 WebKit Review Bot 2010-12-25 00:22:14 PST
Attachment 77434 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7209207
Comment 6 Build Bot 2010-12-25 02:15:39 PST
Attachment 77434 [details] did not build on win:
Build output: http://queues.webkit.org/results/7286175
Comment 7 Eric Seidel (no email) 2010-12-26 13:28:45 PST
Comment on attachment 77434 [details]
Patch

rs=me.
Comment 8 Adam Barth 2011-01-01 22:23:22 PST
http://trac.webkit.org/changeset/74855
Comment 9 Csaba Osztrogon√°c 2011-01-02 08:14:43 PST
One Qt buildfix landed in http://trac.webkit.org/changeset/74869
(Robert was faster than my svn update :) )

But we need one more fix for WebKit2, because 
WebKit2/Scripts/generate-forwarding-headers.pl 
can't handle the Sources/JavaScriptCore directory.

I can check it 4-5 hours later. Or maybe Andras can be faster. :)
Comment 10 Adam Barth 2011-01-02 12:13:45 PST
Thanks guys.  Sorry for the hassle.
Comment 11 Csaba Osztrogon√°c 2011-01-03 03:14:30 PST
Qt-WK2 fix landed: http://trac.webkit.org/changeset/74873 (workaround)

[Qt] run-javascriptcore-tests fix landed: http://trac.webkit.org/changeset/74874

[Qt] BuildSlaveSupport/built-product-archive fix landed:
- http://trac.webkit.org/changeset/74875
- http://trac.webkit.org/changeset/74880

GTK fix landed: http://trac.webkit.org/changeset/74878

Trees are green again. :) Let's see the next rename bug! ;)