Bug 51604

Summary: Move JavaScriptCore to Sources
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, buildbot, dglazkov, eric, gustavo, mjs, ossy, robert, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 51606    
Attachments:
Description Flags
Patch eric: review+

Adam Barth
Reported 2010-12-24 23:48:43 PST
Move JavaScriptCore to Sources
Attachments
Patch (51.90 KB, patch)
2010-12-24 23:53 PST, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-12-24 23:53:22 PST
Created attachment 77434 [details] Patch
Adam Barth
Comment 2 2010-12-24 23:54:37 PST
This patch doesn't actually contain the move because that would make the patch file huge. That means this will show up red on all the EWS bots. I'm going to hold off landing this patch until folks have plenty of warning. I just wanted to get it uploaded so folks could look at it and let me know what I screwed up.
WebKit Review Bot
Comment 3 2010-12-25 00:08:04 PST
Attachment 77434 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7243188
Early Warning System Bot
Comment 4 2010-12-25 00:11:46 PST
Attachment 77434 [details] did not build on qt: Build output: http://queues.webkit.org/results/7200187
WebKit Review Bot
Comment 5 2010-12-25 00:22:14 PST
Attachment 77434 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7209207
Build Bot
Comment 6 2010-12-25 02:15:39 PST
Attachment 77434 [details] did not build on win: Build output: http://queues.webkit.org/results/7286175
Eric Seidel (no email)
Comment 7 2010-12-26 13:28:45 PST
Comment on attachment 77434 [details] Patch rs=me.
Adam Barth
Comment 8 2011-01-01 22:23:22 PST
http://trac.webkit.org/changeset/74855
Csaba Osztrogonác
Comment 9 2011-01-02 08:14:43 PST
One Qt buildfix landed in http://trac.webkit.org/changeset/74869 (Robert was faster than my svn update :) ) But we need one more fix for WebKit2, because WebKit2/Scripts/generate-forwarding-headers.pl can't handle the Sources/JavaScriptCore directory. I can check it 4-5 hours later. Or maybe Andras can be faster. :)
Adam Barth
Comment 10 2011-01-02 12:13:45 PST
Thanks guys. Sorry for the hassle.
Csaba Osztrogonác
Comment 11 2011-01-03 03:14:30 PST
Qt-WK2 fix landed: http://trac.webkit.org/changeset/74873 (workaround) [Qt] run-javascriptcore-tests fix landed: http://trac.webkit.org/changeset/74874 [Qt] BuildSlaveSupport/built-product-archive fix landed: - http://trac.webkit.org/changeset/74875 - http://trac.webkit.org/changeset/74880 GTK fix landed: http://trac.webkit.org/changeset/74878 Trees are green again. :) Let's see the next rename bug! ;)
Note You need to log in before you can comment on or make changes to this bug.