Summary: | Move JavaScriptGlue into Sources | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, eric, mjs, sam, webkit.review.bot, wsiegrist | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 51606 | ||||||||
Attachments: |
|
Description
Adam Barth
2010-12-23 22:40:04 PST
Created attachment 77403 [details]
Patch
Created attachment 77405 [details]
patch
Attachment 77405 [details] did not build on mac: Build output: http://queues.webkit.org/results/7317120 (In reply to comment #3) > Attachment 77405 [details] did not build on mac: > Build output: http://queues.webkit.org/results/7317120 It build locally more me. I suspect the bot is confused. Or that the patch doesn't handle renames? Says it died on this chdir: # Build, and abort if the build fails. for my $dir (@projects) { chdir $dir or die; > Says it died on this chdir:
Right. I bet the directory it's chdiring into (Sources/JavaScriptGlue) doesn't exist on the bot. It does exit locally and seems to build fine.
Comment on attachment 77405 [details]
patch
rs-me
Thanks Darin. I tried to edit those Makefiles but didn't do it correctly. |