Bug 51583

Summary: Move JavaScriptGlue into Sources
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric, mjs, sam, webkit.review.bot, wsiegrist
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 51606    
Attachments:
Description Flags
Patch
none
patch eric: review+, abarth: commit-queue-

Adam Barth
Reported 2010-12-23 22:40:04 PST
Create Sources directory
Attachments
Patch (539 bytes, patch)
2010-12-23 22:41 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
patch (742.31 KB, patch)
2010-12-23 23:32 PST, Adam Barth 		eric: review+
abarth: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-12-23 22:41:06 PST
Created attachment 77403 [details] Patch
Adam Barth
Comment 2 2010-12-23 23:32:46 PST
Created attachment 77405 [details] patch
WebKit Review Bot
Comment 3 2010-12-24 00:27:54 PST
Attachment 77405 [details] did not build on mac: Build output: http://queues.webkit.org/results/7317120
Adam Barth
Comment 4 2010-12-24 00:30:05 PST
(In reply to comment #3) > Attachment 77405 [details] did not build on mac: > Build output: http://queues.webkit.org/results/7317120 It build locally more me. I suspect the bot is confused.
Eric Seidel (no email)
Comment 5 2010-12-24 00:38:01 PST
Or that the patch doesn't handle renames?
Eric Seidel (no email)
Comment 6 2010-12-24 00:40:08 PST
Says it died on this chdir: # Build, and abort if the build fails. for my $dir (@projects) { chdir $dir or die;
Adam Barth
Comment 7 2010-12-24 00:44:14 PST
> Says it died on this chdir: Right. I bet the directory it's chdiring into (Sources/JavaScriptGlue) doesn't exist on the bot. It does exit locally and seems to build fine.
Eric Seidel (no email)
Comment 8 2010-12-24 00:54:49 PST
Comment on attachment 77405 [details] patch rs-me
Adam Barth
Comment 10 2010-12-24 11:32:31 PST
Thanks Darin. I tried to edit those Makefiles but didn't do it correctly.
Note You need to log in before you can comment on or make changes to this bug.