Bug 51561
| Summary: | webkit-patch land should refuse to land if ChangeLog diffs are not at the top | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | CLOSED DUPLICATE | ||
| Severity: | Normal | CC: | eric |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Darin Adler
If you merge wrong, then webkit-patch land will check in and attach the wrong ChangeLog. This could be avoided if webkit-patch checked and refused to land if the only ChangeLog changes are somewhere other than the top of the log.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
I completely agree. It's a little tricky (we don't currently have python code for parsing diffs, and one needs to allow diffs to be up to some N lines from the top in teh case where its the second commit from the same bug/review/etc.)
we should probably dup this to bug 28291. But I guess I should finally take another crack at it.
*** This bug has been marked as a duplicate of bug 28291 ***