Bug 51548

Summary:	check-webkit-style doesn't check all of the ports when linting test expectations
Product:	WebKit	Reporter:	Dirk Pranke <dpranke>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	abarth, eric, jchaffraix, levin, ojan
Priority:	P2	Keywords:	NRWT
Version:	528+ (Nightly build)
Hardware:	PC
OS:	OS X 10.5
Bug Depends on:	51222
Bug Blocks:

Description Dirk Pranke 2010-12-23 11:33:31 PST

The code in the TestExpectations style checker only lints the test expectations file against the port it is running on. It really should be linting against all ports, like new-run-webkit-tests --lint-test-files does.

The easiest fix is to just have it call into the lint routines in webkitpy/layout_tests ... I should probably refactor that logic out of TestRunner and into test_expectations.

Comment 1 Dirk Pranke 2010-12-23 11:34:21 PST

There's no point in fixing this before we fix/land 51222, since all of the logic changes in that fix.

Comment 2 Dirk Pranke 2010-12-23 11:42:10 PST

Bug 51500 gave a false positive on the style bot because of this (as an example).

Comment 3 Dirk Pranke 2010-12-23 11:43:53 PST

There's also a lot of testing duplicated between the style checker and the unit tests for the expectations parser that's kind of unnecessary and can lead to confusion (see, e.g. bug 48426 for an example where one set of tests was updated but the other wasn't).

Comment 4 Dirk Pranke 2012-09-27 12:34:48 PDT

I'm pretty sure I fixed this a while ago. It seems to e be working now.