Bug 51505

Summary:

Detect WebProcess crashes sooner, without waiting for ReportCrash to finish

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	darin: review+

Description Anders Carlsson 2010-12-22 16:02:32 PST

Detect WebProcess crashes sooner, without waiting for ReportCrash to finish

Comment 1 Anders Carlsson 2010-12-22 16:02:50 PST

<rdar://problem/8751641>

Comment 2 Anders Carlsson 2010-12-22 16:07:45 PST

Created attachment 77270 [details]
Patch

Comment 3 Darin Adler 2010-12-22 16:11:58 PST

Comment on attachment 77270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77270&action=review

> WebKit2/Platform/CoreIPC/Connection.h:103
> +    // FIXME: Maybe this should be a flag passed to open?

Maybe, but do we really need leave a FIXME behind?

> WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp:112
> +        m_connectionQueue.registerMachPortEventHandler(m_exceptionPort, WorkQueue::MachPortDataAvailable,
> +                                                       WorkItem::create(this, &Connection::exceptionSourceEventHandler));

I do not like this indenting style. What happens when we rename something later? I think the style guide explicitly says not to do this.

Comment 4 Anders Carlsson 2010-12-22 16:15:42 PST

Committed r74514: <http://trac.webkit.org/changeset/74514>

Comment 5 WebKit Review Bot 2010-12-22 16:33:35 PST

http://trac.webkit.org/changeset/74514 might have broken SnowLeopard Intel Release (Build)