Bug 51467

Summary:

check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt

Product:

WebKit

Reporter:

Shinichiro Hamaji <hamaji>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch v1	none

Shinichiro Hamaji

Reported 2010-12-22 05:53:35 PST

Currently, we only have JavaScriptCore/qt/api in the exemption list. As suggested in Bug 40911, we should have JavaScriptCore/qt/benchmarks as well. I think we can just make entire JavaScriptCore/qt into the exemption list.

Attachments
Patch v1 (1.87 KB, patch) 2010-12-22 05:56 PST, Shinichiro Hamaji	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Shinichiro Hamaji

Comment 1 2010-12-22 05:56:46 PST

Created attachment 77212 [details] Patch v1

Eric Seidel (no email)

Comment 2 2010-12-24 01:40:03 PST

Comment on attachment 77212 [details] Patch v1 OK.

WebKit Commit Bot

Comment 3 2010-12-24 02:19:20 PST

Comment on attachment 77212 [details] Patch v1 Clearing flags on attachment: 77212 Committed r74621: <http://trac.webkit.org/changeset/74621>

WebKit Commit Bot

Comment 4 2010-12-24 02:19:26 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.