Bug 51467 - check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
Summary: check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-22 05:53 PST by Shinichiro Hamaji
Modified: 2010-12-24 02:19 PST (History)
1 user (show)

See Also:


Attachments
Patch v1 (1.87 KB, patch)
2010-12-22 05:56 PST, Shinichiro Hamaji
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2010-12-22 05:53:35 PST
Currently, we only have JavaScriptCore/qt/api in the exemption list. As suggested in Bug 40911, we should have JavaScriptCore/qt/benchmarks as well. I think we can just make entire JavaScriptCore/qt into the exemption list.
Comment 1 Shinichiro Hamaji 2010-12-22 05:56:46 PST
Created attachment 77212 [details]
Patch v1
Comment 2 Eric Seidel (no email) 2010-12-24 01:40:03 PST
Comment on attachment 77212 [details]
Patch v1

OK.
Comment 3 WebKit Commit Bot 2010-12-24 02:19:20 PST
Comment on attachment 77212 [details]
Patch v1

Clearing flags on attachment: 77212

Committed r74621: <http://trac.webkit.org/changeset/74621>
Comment 4 WebKit Commit Bot 2010-12-24 02:19:26 PST
All reviewed patches have been landed.  Closing bug.