Bug 51438

Summary: Can't stop QT music on santastreefarm.com
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Description Flags
Patch darin: review+

Description Anders Carlsson 2010-12-21 17:52:18 PST
Can't stop QT music on santastreefarm.com
Comment 1 Anders Carlsson 2010-12-21 17:52:41 PST
Comment 2 Anders Carlsson 2010-12-21 17:55:26 PST
Created attachment 77174 [details]
Comment 3 Darin Adler 2010-12-21 17:57:09 PST
Comment on attachment 77174 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=77174&action=review

> WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:773
> +static NPBool NPN_ConvertPoint(NPP npp, double sourceX, double sourceY, NPCoordinateSpace sourceSpace, double* destX, double* destY, NPCoordinateSpace destSpace)

I hate the name npp!

> WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:101
> +    switch (sourceSpace) {

Wow, are all these cases covered in testing?

> WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:120
> +        sourceYInScreenSpace = [[[NSScreen screens] objectAtIndex:0] frame].size.height - sourceY;

Seems like we should use a helper function instead of repeating this twice. WebCore has a helper for this, but you could just use a local one.
Comment 4 Anders Carlsson 2010-12-21 18:01:44 PST
Committed r74445: <http://trac.webkit.org/changeset/74445>