Bug 51423

Summary: CopyTex{Sub}Image2D check always if the bound fbo's internal color format is compatible
Product: WebKit Reporter: Zhenyao Mo <zmo>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, enne, kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch kbr: review+

Zhenyao Mo
Reported 2010-12-21 14:51:00 PST
Remove the isGLES2Compliant() flag. Reasons: 1) It's really cheap to do this, and return error earlier is a plus. We track the internal format anyway. might just use it. 2) command buffer port has isGLES2Compliant() set to true, but it doesn't check the color format compatibility.
Attachments
Patch (22.81 KB, patch)
2010-12-22 10:55 PST, Zhenyao Mo 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2010-12-22 10:55:23 PST
Created attachment 77236 [details] Patch
Zhenyao Mo
Comment 2 2010-12-22 10:55:49 PST
The test is in sync with khronos.
Kenneth Russell
Comment 3 2010-12-22 11:54:19 PST
Comment on attachment 77236 [details] Patch Looks good. Test case looks thorough.
Zhenyao Mo
Comment 4 2010-12-22 13:05:25 PST
Committed r74497: <http://trac.webkit.org/changeset/74497>
Note You need to log in before you can comment on or make changes to this bug.