Bug 51398
| Summary: | [Chromium] inspector/console-dir-global.html and inspector/debugger-expand-scope.html are timing out on OSX | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Andrei Popescu <andreip> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | mnaganov, pfeldman, tonyg, yurys, yutak |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Andrei Popescu
In http://trac.webkit.org/changeset/74390/
a change was introduced that causes inspector/console-dir-global.html and inspector/debugger-expand-scope.html layout tests to time out on OSX.
See the first canary that picked up the change:
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac/builds/1988
I will update test_expectations.txt for now, until we work out what the problem is.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Yuta Kitamura
This is strange, because:
- My change does not touch any inspector code; I just added a call to ScriptExecutionContext::addMessage(), and this does not happen in normal code paths (you need to create a WebSocket and cause a network error).
- I added a new console test under http/tests/inspector, but this test should be skipped on Mac and Linux (http://crbug.com/26734).
- These two tests should also be skipped on Mac and Linux.
Yuta Kitamura
My wild guess is that the new test console-websocket-error.html timeouts for some reason (and this is not shown in the bots for some reason) and the following tests are affected by this timeout.
But these tests should not be executed in the first place...
Andrei Popescu
Hi,
(In reply to comment #2)
> My wild guess is that the new test console-websocket-error.html timeouts for some reason (and this is not shown in the bots for some reason) and the following tests are affected by this timeout.
>
> But these tests should not be executed in the first place...
I agree this is all unclear but it's definitely true that the tests were passing before your change. Why exactly should they not be executed in the first place?
Would you mind if we or you rolled out your change just to verify the correlation with the failing tests?
Yuta Kitamura
They should not be executed because inspector tests are skipped on Mac and Linux.
// Add support for inspector layout tests on non-Windows.
BUGCR26734 LINUX MAC SKIP : inspector = PASS
BUGCR26734 LINUX MAC SKIP : http/tests/inspector = PASS
BUGCR26734 LINUX MAC SKIP : http/tests/inspector-enabled = PASS
Yuta Kitamura
A patch in bug 51380 may fix this.
Stephen Chenney
LayoutTest failures for Chromium are being marked WontFix. The Bug is still accessible and referenced from TestExpectations.