Summary: | [GTK] minimal build with --database fails | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Philippe Normand
2010-12-21 06:57:01 PST
Created attachment 77109 [details]
proposed patch
Comment on attachment 77109 [details]
proposed patch
OK.
Does this need both DATABASE and OFFLINE_WEB_APPLICATIONS? (In reply to comment #3) > Does this need both DATABASE and OFFLINE_WEB_APPLICATIONS? Right webkit_set_web_database indeed needs DATABASE. Will fix up and commit, thanks for the review Eric! I'll guard the webkit_set_web_database_directory_path() call with ENABLE(DATABASE) and the cacheStorage() stuff with ENABLE(OFFLINE_WEB_APPLICATIONS) (In reply to comment #5) > I'll guard the webkit_set_web_database_directory_path() call with ENABLE(DATABASE) and the cacheStorage() stuff with ENABLE(OFFLINE_WEB_APPLICATIONS) Oh well ENABLE(DATABASE) is already checked in webkit_set_web_database_directory_path() code, so in the end I don't think it's needed in webkitprivate.cpp Committed r74620: <http://trac.webkit.org/changeset/74620> |