Bug 51391
| Summary: | [v8] trunk/LayoutTests/fast/js/large-expressions.html fails since r74402 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Andrei Popescu <andreip> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ager, barraclough, tonyg |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Andrei Popescu
In http://trac.webkit.org/changeset/74402/
Gavin Barraclough introduced changes in the way stack size is computed on a bunch of platforms. Since that change, the fast/js/large-expressions-expected.txt layout tests fails on Chromium:
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux/builds/4498
Mads, is this something that affects V8?
I will update our test expectations until we figure out a solution.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Mads Ager
We have a stack-size estimate in V8 and I believe the sandbox is currently blocking us from reading the actual stack size. Therefore we cannot follow this easily. Updating test expectations is the right thing for now.
Andrei Popescu
(In reply to comment #1)
> We have a stack-size estimate in V8 and I believe the sandbox is currently blocking us from reading the actual stack size. Therefore we cannot follow this easily. Updating test expectations is the right thing for now.
Andrei Popescu
(In reply to comment #2)
> (In reply to comment #1)
> > We have a stack-size estimate in V8 and I believe the sandbox is currently blocking us from reading the actual stack size. Therefore we cannot follow this easily. Updating test expectations is the right thing for now.
Thanks Mads, I will rebaseline the test and close this bug.
Andrei Popescu
Committed r74413