Bug 51386

Summary:

For box-shadow, non-primary shadow should have specified radius

Product:

WebKit

Reporter:

Hajime Morrita <morrita>

Component:

CSS

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mitz, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
repro.	none
Patch	none
Patch	none
Patch	none
Patch	mitz: review+

Hajime Morrita

Reported 2010-12-21 01:17:25 PST

Created attachment 77093 [details] repro. Reported at: http://habrahabr.ru/blogs/css/103170/ When multiple shadows are specified like -webkit-box-shadow: 110px -25px 0px -10px #D8d8d8, 210px 15px 0px -15px #E0e0e0 , 310px -10px 0px -20px #E8e8e8, 410px 5px 0 -25px #F0f0f0, 510px 0px 0px -30px #F4f4f4; the secondary shadow or later dont have rounded corner even if the source block has border-radius. They should have rounded shadow.

Attachments
repro. (479 bytes, text/html) 2010-12-21 01:17 PST, Hajime Morrita	no flags	Details
Patch (19.14 KB, patch) 2010-12-23 22:56 PST, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch (40.88 KB, patch) 2010-12-26 20:21 PST, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch (27.56 KB, patch) 2010-12-26 20:29 PST, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch (23.67 KB, patch) 2010-12-26 20:38 PST, Hajime Morrita	mitz: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2010-12-21 20:15:07 PST

No, but now I've seen this, I'll fix it.

Simon Fraser (smfr)

Comment 2 2010-12-21 20:23:19 PST

This is essentially a dup of bug 49726. You're using negative spread values, and we don't preserve the radius in that case. *** This bug has been marked as a duplicate of bug 49726 ***

Hajime Morrita

Comment 3 2010-12-21 20:35:58 PST

(In reply to comment #2) > This is essentially a dup of bug 49726. You're using negative spread values, and we don't preserve the radius in that case. Ah, I didn't notice that. Thanks for triaging.

Hajime Morrita

Comment 4 2010-12-23 22:18:41 PST

After some digging, I realized that this is a separate problem. A patch will come shortly.

Hajime Morrita

Comment 5 2010-12-23 22:56:39 PST

Created attachment 77404 [details] Patch

Simon Fraser (smfr)

Comment 6 2010-12-24 08:39:38 PST

Please also add a tests for positive spread on a rectangle, and a rounded rectangle, with normal and inset shadows.

Simon Fraser (smfr)

Comment 7 2010-12-24 11:19:09 PST

Comment on attachment 77404 [details] Patch Please also add a tests for positive spread on a rectangle, and a rounded rectangle, with normal and inset shadows.

Hajime Morrita

Comment 8 2010-12-26 20:21:53 PST

Created attachment 77473 [details] Patch

Hajime Morrita

Comment 9 2010-12-26 20:24:54 PST

Comment on attachment 77473 [details] Patch Attached a bad patch. cancelling....

Hajime Morrita

Comment 10 2010-12-26 20:29:06 PST

Created attachment 77474 [details] Patch

mitz

Comment 11 2010-12-26 20:29:40 PST

Comment on attachment 77474 [details] Patch The test would be better if you removed the text. Then the results would be platform-independent and you could place them in the same directory with the test instead of in platform/mac.

Hajime Morrita

Comment 12 2010-12-26 20:38:15 PST

Created attachment 77475 [details] Patch

Hajime Morrita

Comment 13 2010-12-26 20:42:20 PST

Committed r74673: <http://trac.webkit.org/changeset/74673>

Note You need to log in before you can comment on or make changes to this bug.