Summary: | [GTK] http/tests/inspector/console-websocket-error.html hangs | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yuta Kitamura <yutak> | ||||
Component: | WebKitGTK | Assignee: | Yuta Kitamura <yutak> | ||||
Status: | RESOLVED INVALID | ||||||
Severity: | Normal | CC: | abarth, ap, burg, commit-queue, eric, tyoshino, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Yuta Kitamura
2010-12-20 22:31:33 PST
Created attachment 77203 [details]
Patch
Hi Alexey, I'd like to update the test added in the recent "WebSocket network error to JS console" patch. Could you review this patch? Comment on attachment 77203 [details] Patch Rejecting attachment 77203 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--no-update', '--non-interactive', 77203]" exit_code: 2 Last 500 characters of output: l patching file LayoutTests/platform/gtk/Skipped Hunk #1 FAILED at 5581. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/gtk/Skipped.rej patching file LayoutTests/platform/mac-leopard/http/tests/inspector/console-websocket-error-expected.txt patching file LayoutTests/platform/mac/http/tests/inspector/console-websocket-error-expected.txt Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Alexey Proskuryakov', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7286146 Committed r74611: <http://trac.webkit.org/changeset/74611> Turned out that GTK bots still fail with this patch. :( I will leave the changes to the test and revert only GTK's Skipped file, because this change improves the stability of this test regardless of GTK failure. http://trac.webkit.org/changeset/74611 might have broken GTK Linux 64-bit Debug Committed r74614: <http://trac.webkit.org/changeset/74614> Should this be reopened? Skipped has been migrated to http://trac.webkit.org/browser/trunk/LayoutTests/platform/gtk/TestExpectations This test is still suppressed. Test was removed. |