Bug 51380

Summary: [GTK] http/tests/inspector/console-websocket-error.html hangs
Product: WebKit Reporter: Yuta Kitamura <yutak>
Component: WebKitGTKAssignee: Yuta Kitamura <yutak>
Status: RESOLVED INVALID    
Severity: Normal CC: abarth, ap, burg, commit-queue, eric, tyoshino, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch ap: review+, commit-queue: commit-queue-

Yuta Kitamura
Reported 2010-12-20 22:31:33 PST
The test http/tests/inspector/console-websocket-error.html hangs on the bot and seems to affect the following inspector tests. For now, I'll put this test into the Skipped list. Test output: CONSOLE MESSAGE: line 27: testDNSLookup: Test started. CONSOLE MESSAGE: line 36: testDNSLookup: onclose is called. CONSOLE MESSAGE: line 43: testSSLCertificate: Test started. FAIL: Timed out waiting for notifyDone to be called WebSocket's network errors should be logged to console.
Attachments
Patch (6.54 KB, patch)
2010-12-22 04:39 PST, Yuta Kitamura 		ap: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yuta Kitamura
Comment 1 2010-12-22 04:39:29 PST
Created attachment 77203 [details] Patch
Yuta Kitamura
Comment 2 2010-12-22 04:43:00 PST
Hi Alexey, I'd like to update the test added in the recent "WebSocket network error to JS console" patch. Could you review this patch?
WebKit Commit Bot
Comment 3 2010-12-23 20:33:05 PST
Comment on attachment 77203 [details] Patch Rejecting attachment 77203 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--no-update', '--non-interactive', 77203]" exit_code: 2 Last 500 characters of output: l patching file LayoutTests/platform/gtk/Skipped Hunk #1 FAILED at 5581. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/gtk/Skipped.rej patching file LayoutTests/platform/mac-leopard/http/tests/inspector/console-websocket-error-expected.txt patching file LayoutTests/platform/mac/http/tests/inspector/console-websocket-error-expected.txt Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Alexey Proskuryakov', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7286146
Yuta Kitamura
Comment 4 2010-12-23 20:50:19 PST
Committed r74611: <http://trac.webkit.org/changeset/74611>
Yuta Kitamura
Comment 5 2010-12-23 21:55:31 PST
Turned out that GTK bots still fail with this patch. :( I will leave the changes to the test and revert only GTK's Skipped file, because this change improves the stability of this test regardless of GTK failure.
WebKit Review Bot
Comment 6 2010-12-23 21:55:55 PST
http://trac.webkit.org/changeset/74611 might have broken GTK Linux 64-bit Debug
Yuta Kitamura
Comment 7 2010-12-23 22:05:32 PST
Committed r74614: <http://trac.webkit.org/changeset/74614>
Eric Seidel (no email)
Comment 8 2011-01-11 03:10:30 PST
Should this be reopened?
Takeshi Yoshino
Comment 9 2013-04-08 06:10:00 PDT
Skipped has been migrated to http://trac.webkit.org/browser/trunk/LayoutTests/platform/gtk/TestExpectations This test is still suppressed.
Brian Burg
Comment 10 2014-12-17 17:09:42 PST
Test was removed.
Note You need to log in before you can comment on or make changes to this bug.