Bug 51341

Summary: [Qt] Set BUILDING_QT__ only once
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P4 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch none

Laszlo Gombos
Reported 2010-12-20 11:26:34 PST
Qt build system defines BUILDING_QT__ inconsistently. WebKit.pri sets it to 1, while WebKit2.pro only defines it without a value even though WebKit2.pro includes WebKit.pri. Some other "pro's" don't define it at all and they rely on WebKit.pri.
Attachments
proposed patch (1.95 KB, patch)
2010-12-20 11:32 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2010-12-20 11:32:12 PST
Created attachment 77015 [details] proposed patch
Andreas Kling
Comment 2 2010-12-21 02:54:47 PST
Comment on attachment 77015 [details] proposed patch LGTM
WebKit Commit Bot
Comment 3 2010-12-21 04:40:04 PST
Comment on attachment 77015 [details] proposed patch Clearing flags on attachment: 77015 Committed r74407: <http://trac.webkit.org/changeset/74407>
WebKit Commit Bot
Comment 4 2010-12-21 04:40:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.