Bug 51296

Summary: [Qt] [WK2] Client are expected to render their own background for WebPages
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: commit-queue, kenneth, kling
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Benjamin Poulain 2010-12-18 13:57:52 PST
Client are expected to render their own background for WebPages. This way, clients can choose to render something else than white background when the content is not available yet, for example, the checkerboard pattern as generally used.
Comment 1 Benjamin Poulain 2010-12-18 14:02:44 PST
Created attachment 76942 [details]
Patch

Kenneth, this is similar to the patch you made. There are the following differences:

-remove the call to painter->drawRect(area). This was only drawing 1px border, which is wrong in my opinion
-use QPainter::filerRect() instead of ::drawRect(). ::drawrect has to take into account the pen, ::fillRect is just a memfill in this case.
Comment 2 Kenneth Rohde Christiansen 2010-12-18 14:09:01 PST
Comment on attachment 76942 [details]
Patch

Looks good to me.
Comment 3 Benjamin Poulain 2010-12-18 15:17:51 PST
Created attachment 76945 [details]
Patch

Second part, this is directly taken from the patch of Kenneth.
Comment 4 Benjamin Poulain 2010-12-18 15:18:24 PST
Comment on attachment 76945 [details]
Patch

Removing cq?, I'll cq+ both patches together when this one is reviewed.
Comment 5 Benjamin Poulain 2010-12-18 15:20:46 PST
Note for the reviewer: TiledDrawingAreaProxy is only used by Qt at the moment.
Comment 6 WebKit Commit Bot 2010-12-18 16:00:15 PST
The commit-queue encountered the following flaky tests while processing attachment 76942 [details]:

inspector/debugger-suspend-active-dom-objects.html bug 51301 (author: yurys@chromium.org)
The commit-queue is continuing to process your patch.
Comment 7 Andreas Kling 2010-12-19 01:19:12 PST
Comment on attachment 76945 [details]
Patch

r=me, nice to get rid of this.
Comment 8 WebKit Commit Bot 2010-12-19 07:28:36 PST
Comment on attachment 76945 [details]
Patch

Rejecting attachment 76945 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 76945]" exit_code: 2
Last 500 characters of output:
bexec/git-core/git-svn line 573


Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKit2/ChangeLog
	M	WebKit2/UIProcess/TiledDrawingAreaProxy.cpp
	M	WebKit2/UIProcess/TiledDrawingAreaTile.h
	M	WebKit2/UIProcess/qt/TiledDrawingAreaTileQt.cpp
Merge conflict during commit: Conflict at '/trunk/WebKit2/ChangeLog' at /usr/local/git/libexec/git-core/git-svn line 573


Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1

Full output: http://queues.webkit.org/results/7276060
Comment 9 WebKit Commit Bot 2010-12-19 07:28:48 PST
Comment on attachment 76942 [details]
Patch

Clearing flags on attachment: 76942

Committed r74322: <http://trac.webkit.org/changeset/74322>
Comment 10 Benjamin Poulain 2010-12-19 07:39:35 PST
Comment on attachment 76945 [details]
Patch

Retrying. I don't see why the changelog conflicts. I'll commit manually if that fails.
Comment 11 WebKit Commit Bot 2010-12-19 09:24:21 PST
Comment on attachment 76945 [details]
Patch

Clearing flags on attachment: 76945

Committed r74324: <http://trac.webkit.org/changeset/74324>
Comment 12 WebKit Commit Bot 2010-12-19 09:24:28 PST
All reviewed patches have been landed.  Closing bug.