Bug 51268

Summary: [JSC] parseAssignmentExpression should use TreeBuilder::CreatesAST
Product: WebKit Reporter: Ariya Hidayat <ariya.hidayat>
Component: New BugsAssignee: Ariya Hidayat <ariya.hidayat>
Status: RESOLVED FIXED    
Severity: Normal CC: oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
[JSC] parseAssignmentExpression should use TreeBuilder::CreatesAST none

Ariya Hidayat
Reported 2010-12-17 12:05:25 PST
[JSC] parseAssignmentExpression should use TreeBuilder::CreatesAST
Attachments
[JSC] parseAssignmentExpression should use TreeBuilder::CreatesAST (1.07 KB, patch)
2010-12-17 12:06 PST, Ariya Hidayat 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ariya Hidayat
Comment 1 2010-12-17 12:06:01 PST
Created attachment 76900 [details] [JSC] parseAssignmentExpression should use TreeBuilder::CreatesAST
Ariya Hidayat
Comment 2 2010-12-17 15:11:18 PST
With the patch, there won't be any difference in the code path for JSParser + SyntaxChecker. Currently, the flow will continue to execute createAssignment() function. With the patch, that is skipped all together.
Oliver Hunt
Comment 3 2010-12-17 15:12:32 PST
Comment on attachment 76900 [details] [JSC] parseAssignmentExpression should use TreeBuilder::CreatesAST r=me
Ariya Hidayat
Comment 4 2010-12-17 15:28:56 PST
Comment on attachment 76900 [details] [JSC] parseAssignmentExpression should use TreeBuilder::CreatesAST Clearing flags on attachment: 76900 Committed r74299: <http://trac.webkit.org/changeset/74299>
Ariya Hidayat
Comment 5 2010-12-17 15:29:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.