Bug 51261

Summary: editing/execCommand/toggle-compound-styles-expected should use LayoutTestController::setEditingBehavior
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: kalman, mrobinson, rniwa, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 51163    
Bug Blocks:    
Attachments:
Description Flags
fixes the test tonikitoo: review+

Description Antonio Gomes 2010-12-17 09:00:41 PST
Test goes through platform specific editing behavior code path, so it should be tested using LayoutTestController::setEditingBehavior.

That way we could get rid of platform specific test results. Right now we have:

$ find LayoutTests/ -name toggle-compound-styles*
(...)
LayoutTests/platform/mac/editing/execCommand/toggle-compound-styles-expected.txt
LayoutTests/platform/qt/editing/execCommand/toggle-compound-styles-expected.txt
LayoutTests/platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt
LayoutTests/platform/win/editing/execCommand/toggle-compound-styles-expected.txt
Comment 1 Antonio Gomes 2010-12-17 09:08:24 PST
Bug revealed by bug 51163
Comment 2 Ryosuke Niwa 2010-12-17 10:33:53 PST
Created attachment 76889 [details]
fixes the test
Comment 3 Ryosuke Niwa 2010-12-17 10:58:37 PST
Committed r74279: <http://trac.webkit.org/changeset/74279>