| Summary: | [chromium] canvas.toDataURL("image/jpeg") should composite onto black | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | noel gordon <noel.gordon> | ||||||||||
| Component: | Canvas | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, eric, hbono, levin, mdelaney7, mikelawther, oliver, senorblanco | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Windows 7 | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 67402 | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 76855 [details]
patch
Comment on attachment 76855 [details]
patch
Doesn't this need to include pixel test updates and or test_expectations.txt updates?
Oliver knows way more about canvas than I do. > Oliver knows way more about canvas than I do.
No worries, that's why I added Stephen. Bear with me a moment while I update another patch.
Created attachment 76858 [details]
patch
Created attachment 76964 [details]
patch update changelog description
(In reply to comment #2) > Doesn't this need to include pixel test updates and or test_expectations.txt updates? yes, added test_expectations.txt update. Created attachment 76977 [details]
patch update test_expectations.txt
Comment on attachment 76977 [details]
patch update test_expectations.txt
Looks good to me.
Comment on attachment 76977 [details] patch update test_expectations.txt Clearing flags on attachment: 76977 Committed r75488: <http://trac.webkit.org/changeset/75488> All reviewed patches have been landed. Closing bug. resolved http://www.w3.org/Bugs/Public/show_bug.cgi?id=11431 WONTFIX |
[chromium] canvas.toDataURL("image/jpeg") composite onto black