Bug 51233

Summary: [Qt] Default image interpolation should reset the render hint
Product: WebKit Reporter: Ariya Hidayat <ariya.hidayat>
Component: Layout and RenderingAssignee: Ariya Hidayat <ariya.hidayat>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, kling, webkit-ews
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
[Qt] Default image interpolation should reset the render hint
none
[Qt] Default image interpolation should reset the render hint none

Description Ariya Hidayat 2010-12-16 22:50:43 PST
Setting image interpolation quality to 'default' sets the SmoothPixmapTransform render hint. This breaks the low-quality painting logic in GraphicsContext::drawImage. The reason is because the logic involves the steps: save current image interpolation quality, set the quality to low, draw the image, revert back the quality to the original. Thus, default must serve as a way to reset the render hint (to the original), otherwise the SmoothPixmapTransform render hint will be set forever.
Comment 1 Ariya Hidayat 2010-12-16 23:36:37 PST
Created attachment 76849 [details]
[Qt] Default image interpolation should reset the render hint
Comment 2 Early Warning System Bot 2010-12-16 23:47:35 PST
Attachment 76849 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7255006
Comment 3 Ariya Hidayat 2010-12-17 00:00:51 PST
Created attachment 76851 [details]
[Qt] Default image interpolation should reset the render hint
Comment 4 Andreas Kling 2010-12-17 02:53:01 PST
Comment on attachment 76851 [details]
[Qt] Default image interpolation should reset the render hint

Thanks for fixing this! r=me
Comment 5 Ariya Hidayat 2010-12-17 08:43:14 PST
Comment on attachment 76851 [details]
[Qt] Default image interpolation should reset the render hint

Clearing flags on attachment: 76851

Committed r74272: <http://trac.webkit.org/changeset/74272>
Comment 6 Ariya Hidayat 2010-12-17 08:43:21 PST
All reviewed patches have been landed.  Closing bug.