Bug 51199

Summary: Add tests for UTF-16 decoding and its variants
Product: WebKit Reporter: Yong Li <yong.li.webkit>
Component: TextAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
ap: review+, yong.li.webkit: commit-queue-
added comments none

Yong Li
Reported 2010-12-16 10:59:28 PST
51035 is closed as invalid. But the tests are good to have.
Attachments
the patch (4.38 KB, patch)
2010-12-16 11:42 PST, Yong Li 		ap: review+
yong.li.webkit: commit-queue-
DetailsFormatted DiffDiff
added comments (4.52 KB, patch)
2010-12-16 12:33 PST, Yong Li 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yong Li
Comment 1 2010-12-16 11:42:45 PST
Created attachment 76794 [details] the patch
Alexey Proskuryakov
Comment 2 2010-12-16 11:54:55 PST
Comment on attachment 76794 [details] the patch Thank you! Please consider adding an explanation of expected results as a comment in the test (something like "According to HTML5 and for IE compatibility, UTF-16 is treated as little endian. These subtest fail as of Firefox 3.6.13.") To mention that the test fail in Firefox, you'll need to separate those that actually do (UTF-16LE and unicodeFEFF should obviously pass everywhere).
Yong Li
Comment 3 2010-12-16 12:33:54 PST
Created attachment 76801 [details] added comments
WebKit Commit Bot
Comment 4 2010-12-16 18:29:01 PST
Comment on attachment 76801 [details] added comments Clearing flags on attachment: 76801 Committed r74225: <http://trac.webkit.org/changeset/74225>
WebKit Commit Bot
Comment 5 2010-12-16 18:29:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.