Bug 51189

Summary: Web Inspector: Console always scroll to the bottom on new events
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, eric, jerem.selier, joepeck, keishi, loislo, mathias, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
timothy: review+
Patch none

Description Yury Semikhatsky 2010-12-16 07:56:01 PST 
Console should not scroll to the bottom while scrolled up.
Comment 1 Yury Semikhatsky 2010-12-16 08:01:02 PST 
Created attachment 76769 [details]
Patch
Comment 2 Pavel Feldman 2010-12-16 08:29:25 PST 
Comment on attachment 76769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76769&action=review

> WebCore/inspector/front-end/ConsoleView.js:215
> +    _isScrolledToLastMessage: function()

Can we define this on Element.prototype instead and reuse in DataGrid?
Comment 3 Yury Semikhatsky 2010-12-16 08:39:56 PST 
Created attachment 76772 [details]
Patch
Comment 4 Yury Semikhatsky 2010-12-16 08:40:42 PST 
Done.
(In reply to comment #2)
> (From update of attachment 76769 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=76769&action=review
> 
> > WebCore/inspector/front-end/ConsoleView.js:215
> > +    _isScrolledToLastMessage: function()
> 
> Can we define this on Element.prototype instead and reuse in DataGrid?
Comment 5 Yury Semikhatsky 2010-12-16 08:57:16 PST 
Comment on attachment 76772 [details]
Patch

Clearing flags on attachment: 76772

Committed r74193: <http://trac.webkit.org/changeset/74193>
Comment 6 Yury Semikhatsky 2010-12-16 08:57:26 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2010-12-16 15:39:07 PST 
http://trac.webkit.org/changeset/74193 might have broken Leopard Intel Debug (Tests)