Bug 51184

Summary: Web Inspector: remove unnecessary dependencies from InspectorBackendStub
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, commit-queue, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[patch] first iteration. none

Ilya Tikhonovsky
Reported 2010-12-16 05:58:43 PST
InspectorBackendStub is a transport-only thing but it has dependencies with Callback.js and WebInspector namespace. Callback can be integrated into InspectorBackendStub because it is the only client. Without these dependencies InspectorBackendStub can be used as an API wrapper for Inspector Protocol.
Attachments
[patch] first iteration. (8.42 KB, patch)
2010-12-16 06:04 PST, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2010-12-16 06:04:13 PST
Created attachment 76763 [details] [patch] first iteration.
Ilya Tikhonovsky
Comment 2 2010-12-17 00:30:06 PST
Comment on attachment 76763 [details] [patch] first iteration. Clearing flags on attachment: 76763 Committed r74236: <http://trac.webkit.org/changeset/74236>
Ilya Tikhonovsky
Comment 3 2010-12-17 00:30:18 PST
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 4 2010-12-17 01:24:22 PST
The commit-queue encountered the following flaky tests while processing attachment 76763 [details]: http/tests/misc/redirect.php bug 51238 (author: mjs@apple.com) inspector/styles-new-API.html bug 50889 (authors: apavlov@chromium.org and pfeldman@chromium.org) The commit-queue is continuing to process your patch.
Note You need to log in before you can comment on or make changes to this bug.