Bug 51174

Summary: Web Inspector: status message isn't shown in call stack sidebar pane for native breakpoints
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch. yurys: review+

Description Pavel Podivilov 2010-12-16 03:16:42 PST
Web Inspector: status message isn't shown in call stack sidebar pane for native breakpoints
Comment 1 Pavel Podivilov 2010-12-16 03:18:29 PST
Created attachment 76748 [details]
Patch.

Update CallStackSidebarPane placards and status message in the same event handler so it doesn't depend on event dispatch order.
Comment 2 Yury Semikhatsky 2010-12-16 06:05:39 PST
Comment on attachment 76748 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=76748&action=review

> WebCore/inspector/front-end/BreakpointManager.js:181
> +        this._lastHitBreakpointView = breakpointView;

Breakpoint manager shouldn't modify breakpoint views, instead each view should listen to the corresponding breakpoint state changes and update itself. BreakpointManager should operate on the breakpoints. r- for this.
Comment 3 Pavel Podivilov 2010-12-16 06:40:43 PST
(In reply to comment #2)
> (From update of attachment 76748 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=76748&action=review
> 
> > WebCore/inspector/front-end/BreakpointManager.js:181
> > +        this._lastHitBreakpointView = breakpointView;
> 
> Breakpoint manager shouldn't modify breakpoint views, instead each view should listen to the corresponding breakpoint state changes and update itself. BreakpointManager should operate on the breakpoints. r- for this.

This patch is just a quick fix, relations between BreakpointManager and breakpoint views didn't change. I've just renamed _lastHitBreakpoint.view to _lastHitBreakpointView.

Let me decouple breakpoint views from breakpoint manager in a separate patch.
Comment 4 Pavel Podivilov 2010-12-16 07:58:26 PST
Committed r74191: <http://trac.webkit.org/changeset/74191>
Comment 5 WebKit Review Bot 2010-12-16 15:38:56 PST
http://trac.webkit.org/changeset/74191 might have broken Leopard Intel Debug (Tests)