Bug 51169

Summary:

[Qt][S60] Vertical borders of buttons and frames are misaligned

Product:

WebKit

Reporter:

varun <varun.jajee>

Component:

WebKit Qt

Assignee:

Janne Koskinen <koshuin>

Status:

RESOLVED FIXED

Severity:

Critical

CC:

ademar, ankur.baranwal, benjamin, commit-queue, kasthuri.n-s, koshuin, laszlo.gombos, prasad.adimulam, suresh.voruganti, varun.jajee

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

S60 Hardware

OS:

S60 3rd edition

Attachments:

Description	Flags
Screenshots	none
patch for QtWebkit2.1 branch	none
Patch proposal for trunk	none
patch proposal for trunk - changelog fixed	none
patch for QtWebkit2.1 branch - log fixed	none

varun

Reported 2010-12-15 23:42:40 PST

Created attachment 76739 [details] Screenshots Most buttons, panels, and frames are rendering incorrectly. The vertical sides of the elements are not lining up with the corners. The vertical borders shift 1px to right for all elements, including the list panel. See the attached screen shots. Steps to reproduce the issue for a simple button: ------------------------ <html><body> <input type="button" value="Border Test Button"/> </body><html> ------------------------ 1. Save above html code in a file (say "e:/a.html"). 2. Open QtTestBrowser. 3. Enter "e:/a.html" in the address bar and press refresh button. Actual Result: HTML page with a button is displayed. Border of the button is not aligned properly. Additional Info: Qt - 4.7 QtWebkit - 2.1 OS - Sumbian^3 Issue has been moved from wrt team Boston defect 7315.

Attachments
Screenshots (87.62 KB, application/x-zip-compressed) 2010-12-15 23:42 PST, varun	no flags	Details
patch for QtWebkit2.1 branch (1.81 KB, patch) 2011-02-10 09:41 PST, Janne Koskinen	no flags	Details Formatted Diff Diff
Patch proposal for trunk (1.84 KB, patch) 2011-02-10 10:24 PST, Janne Koskinen	no flags	Details Formatted Diff Diff
patch proposal for trunk - changelog fixed (1.81 KB, patch) 2011-02-11 00:40 PST, Janne Koskinen	no flags	Details Formatted Diff Diff
patch for QtWebkit2.1 branch - log fixed (1.78 KB, patch) 2011-02-11 01:22 PST, Janne Koskinen	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Prasad

Comment 1 2011-01-06 13:11:36 PST

Related QtWRT Bugzilla error ID: http://bugs.nokia-boston.com/bugzilla/show_bug.cgi?id=7315

Suresh Voruganti

Comment 2 2011-01-07 06:30:44 PST

Fix required for Qtwebkit 2.2

Benjamin Poulain

Comment 3 2011-01-28 17:39:21 PST

Please follow http://trac.webkit.org/wiki/QtWebKitBugs when reporing bug here (missing the keyword Qt). (In reply to comment #2) > Fix required for Qtwebkit 2.2 Is this seriously a blocker for 2.1.x? Are you sure it is a bug in WebKit at all? I would think this is part of common code and the bug is in Qt.

Janne Koskinen

Comment 4 2011-01-31 02:12:33 PST

> Is this seriously a blocker for 2.1.x? Are you sure it is a bug in WebKit at all? I would think this is part of common code and the bug is in Qt. This issue happens with mobile webkit style only if OpenVG backend is used, raster engine is fine. AFAIK Qt buttons don't have this issue.

kasthuri

Comment 5 2011-01-31 11:26:38 PST

I spent some time on this issue. It seems to happen only with Qt mobile theme enabled as Janne has pointed out. If we disable Qt mobile style, then everything seems to be ok. I think the themeQtMobile.css is not liked by symbian.

Benjamin Poulain

Comment 6 2011-01-31 11:30:36 PST

(In reply to comment #5) > I spent some time on this issue. It seems to happen only with Qt mobile theme enabled as Janne has pointed out. If we disable Qt mobile style, then everything seems to be ok. I think the themeQtMobile.css is not liked by symbian. That already some info... Maybe a property used by the theme is not well supported on Symbian. Have you tried with the raster graphic system and the mobile theme?

kasthuri

Comment 7 2011-01-31 12:13:55 PST

(In reply to comment #6) > (In reply to comment #5) > > I spent some time on this issue. It seems to happen only with Qt mobile theme enabled as Janne has pointed out. If we disable Qt mobile style, then everything seems to be ok. I think the themeQtMobile.css is not liked by symbian. > That already some info... > Maybe a property used by the theme is not well supported on Symbian. > Have you tried with the raster graphic system and the mobile theme? Raster graphic system is working fine.

Benjamin Poulain

Comment 8 2011-01-31 12:22:10 PST

(In reply to comment #7) > Raster graphic system is working fine. Could you make a reduction? That way you could create a bug for Qt and close the bug here.

Janne Koskinen

Comment 9 2011-02-09 00:53:08 PST

This is actually bug/feature in the OpenVG hardware. Unfortunately we need to workaround this in QtWebkit. I'm preparing a patch.

Janne Koskinen

Comment 10 2011-02-10 09:41:51 PST

Created attachment 81994 [details] patch for QtWebkit2.1 branch OpenVG backend cannot guarantee pixel rendering to be correct in non-integer boundaries unless antialising is used. Patch checks if the backend is OpenVg and forces lines to be drawn.

Suresh Voruganti

Comment 11 2011-02-10 09:44:01 PST

Adding to Qtwebkit 2.1 Master bug for cherry picking the fix to Qtwebkit 2.1

Janne Koskinen

Comment 12 2011-02-10 09:45:44 PST

(In reply to comment #10) > Patch checks if the backend is OpenVg and forces lines to be drawn antialiased. Getting late again :)

Janne Koskinen

Comment 13 2011-02-10 10:24:12 PST

Created attachment 81998 [details] Patch proposal for trunk There is no layout test for this as it would require pixel per pixel analysis of render.

Benjamin Poulain

Comment 14 2011-02-10 10:55:10 PST

Comment on attachment 81998 [details] Patch proposal for trunk View in context: https://bugs.webkit.org/attachment.cgi?id=81998&action=review > Source/WebCore/ChangeLog:12 > + No new tests. (OOPS!) You should remove that line.

Laszlo Gombos

Comment 15 2011-02-10 19:56:28 PST

Looks good to me, please fix ChangeLog.

Janne Koskinen

Comment 16 2011-02-11 00:40:15 PST

Created attachment 82112 [details] patch proposal for trunk - changelog fixed

Janne Koskinen

Comment 17 2011-02-11 01:22:52 PST

Created attachment 82114 [details] patch for QtWebkit2.1 branch - log fixed

Andreas Kling

Comment 18 2011-02-11 02:48:34 PST

Comment on attachment 82112 [details] patch proposal for trunk - changelog fixed r=me

WebKit Commit Bot

Comment 19 2011-02-11 05:19:49 PST

Comment on attachment 82112 [details] patch proposal for trunk - changelog fixed Clearing flags on attachment: 82112 Committed r78332: <http://trac.webkit.org/changeset/78332>

WebKit Commit Bot

Comment 20 2011-02-11 05:19:55 PST

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 21 2011-02-11 05:21:35 PST

The commit-queue encountered the following flaky tests while processing attachment 82112 [details]: http/tests/websocket/tests/multiple-connections.html bug 53825 (author: abarth@webkit.org) The commit-queue is continuing to process your patch.

Ademar Reis

Comment 22 2011-02-14 12:06:55 PST

Revision r78332 cherry-picked into qtwebkit-2.1 with commit 30058fe <http://gitorious.org/webkit/qtwebkit/commit/30058fe>

Note You need to log in before you can comment on or make changes to this bug.