Bug 51137

Summary:

IOSurface bounds checks on bytesPerRow and allocSize are incorrect

Product:

WebKit

Reporter:

Matthew Delaney <mdelaney7>

Component:

Canvas

Assignee:

Matthew Delaney <mdelaney7>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mdelaney7, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac (Intel)

OS:

OS X 10.6

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Matthew Delaney 2010-12-15 14:56:34 PST

Since the IOSurfaceAlignProperty functions may align bytesPerRow and allocSize for reasons other than not allowing the values to be too large, bounds checking off of their returned values is not correct.

This patch will remove those incorrect bounds checks.

Comment 1 Matthew Delaney 2010-12-15 15:05:21 PST

Created attachment 76690 [details]
Patch

Comment 2 Eric Seidel (no email) 2010-12-15 15:15:41 PST

Comment on attachment 76690 [details]
Patch

Which tests?  On which platform?

Comment 3 Simon Fraser (smfr) 2010-12-15 15:20:18 PST

Comment on attachment 76690 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76690&action=review

> WebCore/ChangeLog:8
> +        No new tests added - many current canvas layout tests fail because of this incorrect bounds check.

You should clarify that tests will only fail for those using this new functionality.

Comment 4 Matthew Delaney 2010-12-15 15:28:20 PST

Yea, exactly. Only on my local build using this new functionality (IOSurfaces) are any of the usual tests failing. This patch will fix those - not any tests failing on the bots. This is now reflected in the changelog.

Comment 5 Matthew Delaney 2010-12-15 15:28:31 PST

Committed r74148: <http://trac.webkit.org/changeset/74148>