Bug 51089

Summary: text-combine value name changed
Product: WebKit Reporter: Takumi Takano <takano>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, commit-queue, hyatt, mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 48538    
Attachments:
Description Flags
Proposed patch.
mitz: review-
New proposed patch. none

Description Takumi Takano 2010-12-14 20:17:37 PST 
text-combine's value names were changed from "none|cluster|upright" to "none|horizontal" in the latest css3 proposal.
Comment 1 Takumi Takano 2010-12-14 20:40:49 PST 
Created attachment 76623 [details]
Proposed patch.
Comment 2 mitz 2010-12-14 20:50:28 PST 
Comment on attachment 76623 [details]
Proposed patch.

Good, but you should also update the size of the bit field in StyleRareNomInheritedData.
Comment 3 Takumi Takano 2010-12-14 21:26:56 PST 
Created attachment 76629 [details]
New proposed patch.

Changed textCombine field size in StyleRareNonInheritedData.h.
Comment 4 WebKit Commit Bot 2010-12-14 22:47:08 PST 
The commit-queue encountered the following flaky tests while processing attachment 76629 [details]:

inspector/styles-source-offsets.html bug 51095 (authors: apavlov@chromium.org and pfeldman@chromium.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2010-12-14 22:49:01 PST 
Comment on attachment 76629 [details]
New proposed patch.

Clearing flags on attachment: 76629

Committed r74098: <http://trac.webkit.org/changeset/74098>
Comment 6 WebKit Commit Bot 2010-12-14 22:49:06 PST 
All reviewed patches have been landed.  Closing bug.