Bug 51085

Summary: Skip Chromium related test cases for media unimplemented features
Product: WebKit Reporter: imasaki
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hclam, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Description imasaki 2010-12-14 18:48:59 PST
Skip Chromium related test cases for media unimplemented features
Comment 1 imasaki 2010-12-14 18:50:09 PST
Created attachment 76611 [details]
Patch
Comment 2 David Levin 2010-12-14 19:01:38 PST
It would be good to answer the following somewhere: What feature is unimplemented? Is it never going to be implemented?
Comment 3 imasaki 2010-12-15 13:35:37 PST
Created attachment 76685 [details]
Patch
Comment 4 David Levin 2010-12-15 13:38:51 PST
Comment on attachment 76685 [details]
Patch

I just noticed that the reasons for the skips are already in the test_expectations. Sorry for missing that before.
Comment 5 imasaki 2010-12-15 13:44:17 PST
Hi, David, can you approve the change?
Comment 6 WebKit Commit Bot 2010-12-15 15:09:26 PST
The commit-queue encountered the following flaky tests while processing attachment 76685 [details]:

media/invalid-media-url-crash.html bug 51138 (author: inferno@chromium.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2010-12-15 15:10:46 PST
Comment on attachment 76685 [details]
Patch

Clearing flags on attachment: 76685

Committed r74146: <http://trac.webkit.org/changeset/74146>
Comment 8 WebKit Commit Bot 2010-12-15 15:10:53 PST
All reviewed patches have been landed.  Closing bug.