| Summary: | Percentage Z values in 3d transform functions and transform-origin should cause the property to be invalid | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | CSS | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cmarrin, dino, simon.fraser, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2010-12-14 16:03:13 PST
This already works for -webkit-transform-origin. Created attachment 76631 [details]
Patch
Attachment 76631 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/transforms/2d/resources/transform-test-utils.js', u'LayoutTests/transforms/3d/general/3dtransform-values-expected.txt', u'LayoutTests/transforms/3d/general/3dtransform-values.html', u'WebCore/ChangeLog', u'WebCore/css/CSSParser.cpp']" exit_code: 1
WebCore/css/CSSParser.cpp:5006: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 76631 [details]
Patch
r+ with the comment change to get rid of transform-origin wording. You should also fix the style issue, unless it's just noise from the style bot
|