Bug 51065

Summary: [git].DS_Store should be in .gitignore
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: abarth, eric, evan, mihaip, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Adds *.DS_Store to .gitignore
none
Adds .DS_Store to .gitignore eric: review+

Ryosuke Niwa
Reported 2010-12-14 15:36:59 PST
AFAIK, there's no point in tracking changes to .DS_Store. It should be in .gitignore.
Attachments
Adds *.DS_Store to .gitignore (627 bytes, patch)
2010-12-14 15:39 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Adds .DS_Store to .gitignore (667 bytes, patch)
2010-12-14 15:44 PST, Ryosuke Niwa 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2010-12-14 15:39:13 PST
Created attachment 76583 [details] Adds *.DS_Store to .gitignore
Eric Seidel (no email)
Comment 2 2010-12-14 15:42:21 PST
Comment on attachment 76583 [details] Adds *.DS_Store to .gitignore You don't need the * , just .DS_Store
Ryosuke Niwa
Comment 3 2010-12-14 15:44:18 PST
Created attachment 76586 [details] Adds .DS_Store to .gitignore
Eric Seidel (no email)
Comment 4 2010-12-14 15:54:45 PST
Comment on attachment 76586 [details] Adds .DS_Store to .gitignore ok
Ryosuke Niwa
Comment 5 2010-12-14 16:19:28 PST
Committed r74067: <http://trac.webkit.org/changeset/74067>
WebKit Review Bot
Comment 6 2010-12-14 17:18:34 PST
http://trac.webkit.org/changeset/74067 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: fast/css/focus-ring-detached.html fast/css/focus-ring-multiline.html
Ryosuke Niwa
Comment 7 2010-12-14 19:12:01 PST
Thanks for the quick review, Eric. (In reply to comment #4) > (From update of attachment 76586 [details]) > ok
Note You need to log in before you can comment on or make changes to this bug.