Bug 51044

Summary:

[V8] Get rid of delayed exception reporting in V8ConsoleMessage.cpp

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

WebCore Misc.

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, antonm, pfeldman

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

8519

Bug Blocks:

Attachments:

Description	Flags
Patch	abarth: review+, abarth: commit-queue-
Patch that I'm going to land.	none

Description Yury Semikhatsky 2010-12-14 10:22:07 PST

Get rid of delayed exception reporting in V8ConsoleMessage.cpp. All exceptions/errors can be reported immediately.

Comment 1 Yury Semikhatsky 2010-12-14 10:26:56 PST

Created attachment 76545 [details]
Patch

Comment 2 Adam Barth 2010-12-14 12:20:05 PST

Comment on attachment 76545 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76545&action=review

Great.  I'm glad to be rid of this complexity.

> WebCore/bindings/v8/V8DOMWindowShell.cpp:102
> +    Document* document = frame->document();
> +    if (!document)
> +        return;

document can never be null.

> WebCore/bindings/v8/V8DOMWindowShell.cpp:116
> +    String resourceNameString = useURL ? frame->document()->url() : toWebCoreString(resourceName);

You've already got document in a local variable.  No need to go back to the Frame.

Comment 3 Yury Semikhatsky 2011-01-20 04:25:01 PST

Created attachment 79578 [details]
Patch that I'm going to land.

All comments have been addressed.

Comment 4 Yury Semikhatsky 2011-01-20 04:31:50 PST

Committed r76224: <http://trac.webkit.org/changeset/76224>