Bug 51044 - [V8] Get rid of delayed exception reporting in V8ConsoleMessage.cpp
Summary: [V8] Get rid of delayed exception reporting in V8ConsoleMessage.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on: 8519
Blocks:
  Show dependency tree / graph
 
Reported: 2010-12-14 10:22 PST by Yury Semikhatsky
Modified: 2011-01-20 04:31 PST (History)
3 users (show)

See Also:

Attachments
Patch (22.76 KB, patch)
2010-12-14 10:26 PST, Yury Semikhatsky 		abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff
Patch that I'm going to land. (22.25 KB, patch)
2011-01-20 04:25 PST, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2010-12-14 10:22:07 PST 
Get rid of delayed exception reporting in V8ConsoleMessage.cpp. All exceptions/errors can be reported immediately.
Comment 1 Yury Semikhatsky 2010-12-14 10:26:56 PST 
Created attachment 76545 [details]
Patch
Comment 2 Adam Barth 2010-12-14 12:20:05 PST 
Comment on attachment 76545 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76545&action=review

Great.  I'm glad to be rid of this complexity.

> WebCore/bindings/v8/V8DOMWindowShell.cpp:102
> +    Document* document = frame->document();
> +    if (!document)
> +        return;

document can never be null.

> WebCore/bindings/v8/V8DOMWindowShell.cpp:116
> +    String resourceNameString = useURL ? frame->document()->url() : toWebCoreString(resourceName);

You've already got document in a local variable.  No need to go back to the Frame.
Comment 3 Yury Semikhatsky 2011-01-20 04:25:01 PST 
Created attachment 79578 [details]
Patch that I'm going to land.

All comments have been addressed.
Comment 4 Yury Semikhatsky 2011-01-20 04:31:50 PST 
Committed r76224: <http://trac.webkit.org/changeset/76224>