| Summary: | [GTK] Unsigned values substraction bug in SoupCache | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michal Pakula vel Rutka <mpakulavelrutka> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED WONTFIX | ||||||
| Severity: | Normal | CC: | gyuyoung.kim, miroslaw.s, mrobinson, svillar | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
Created attachment 76534 [details]
[GTK] Unsigned values substraction bug in SoupCache
The bug indeed exists but I have already fixed it in libsoup as the SoupCache code was imported there during this year's hackfest. I don't think it makes sense to fix it in WebKit as the SoupCache code will be removed soon. Thanks for the update Sergio. There's no point fixing this as the code will be nuked soon. OK, I didn't knew that WebKit SoupCache is going to be removed shortly. Could you estimate when will it happen? (In reply to comment #4) > OK, I didn't knew that WebKit SoupCache is going to be removed shortly. Could you estimate when will it happen? We're waiting for Google guys to update the EWS bots Comment on attachment 76534 [details]
[GTK] Unsigned values substraction bug in SoupCache
Removing from review queue.
|
There is bug soup-http-input-stream.c in function webkit_soup_http_input_stream_got_chunk at line 270: if (priv->caller_bufsize - priv->caller_nread > 0) { as both of values type is gsize which unsigned int it always will be greater than zero when values are different.