Bug 51034

Summary: Web Inspector: Rule data not updated in Styles pane after stylesheet gets reverted
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Suggested fix
yurys: review-
[PATCH] Comment addressed yurys: review+

Alexander Pavlov (apavlov)
Reported 2010-12-14 06:58:42 PST
After a stylesheet is reverted in the Resources panel, the rule data for the current element do not get updated, even if the revert has altered the respective styles.
Attachments
[PATCH] Suggested fix (2.99 KB, patch)
2010-12-14 08:25 PST, Alexander Pavlov (apavlov) 		yurys: review-
DetailsFormatted DiffDiff
[PATCH] Comment addressed (3.22 KB, patch)
2010-12-14 09:36 PST, Alexander Pavlov (apavlov) 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2010-12-14 08:25:36 PST
Created attachment 76539 [details] [PATCH] Suggested fix
Yury Semikhatsky
Comment 2 2010-12-14 09:08:26 PST
Comment on attachment 76539 [details] [PATCH] Suggested fix View in context: https://bugs.webkit.org/attachment.cgi?id=76539&action=review > WebCore/inspector/front-end/CSSStyleModel.js:177 > + if (WebInspector.panels.elements) The panel should listen to changes in the model. The model could send such notifications from _styleSheetChanged a change has been successfully committed.
Alexander Pavlov (apavlov)
Comment 3 2010-12-14 09:36:31 PST
Created attachment 76542 [details] [PATCH] Comment addressed
Alexander Pavlov (apavlov)
Comment 4 2010-12-14 10:06:53 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/CSSStyleModel.js M WebCore/inspector/front-end/ElementsPanel.js Committed r74038
Note You need to log in before you can comment on or make changes to this bug.