Bug 51025

Summary: Web Inspector: regroup Inspector.idl entries.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, ap, bweinstein, commit-queue, dinhphuong569, jedymark001, joepeck, keishi, kenkoiii001, kihoslohun, loislo, mikayla, mytrinh061995, nagar28496, nodejsquiz, pfeldman, pmuellr, rik, spirulinamanfaat, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 51293    
Attachments:
Description Flags
[patch] first version
none
Inspector.idl
none
[patch] extended version with comments none

Ilya Tikhonovsky
Reported 2010-12-14 03:58:27 PST
just for better visibility.
Attachments
[patch] first version (21.79 KB, patch)
2010-12-14 04:03 PST, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Inspector.idl (15.81 KB, text/x-idl)
2010-12-14 04:03 PST, Ilya Tikhonovsky 		no flags
Details
[patch] extended version with comments (25.46 KB, patch)
2010-12-14 06:18 PST, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2010-12-14 04:03:06 PST
Created attachment 76524 [details] [patch] first version
Ilya Tikhonovsky
Comment 2 2010-12-14 04:03:53 PST
Created attachment 76525 [details] Inspector.idl
Ilya Tikhonovsky
Comment 3 2010-12-14 06:18:46 PST
Created attachment 76529 [details] [patch] extended version with comments
Ilya Tikhonovsky
Comment 4 2010-12-14 06:54:55 PST
Comment on attachment 76529 [details] [patch] extended version with comments Clearing flags on attachment: 76529 Committed r74022: <http://trac.webkit.org/changeset/74022>
Ilya Tikhonovsky
Comment 5 2010-12-14 06:55:06 PST
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 6 2010-12-14 09:30:27 PST
Comment on attachment 76529 [details] [patch] extended version with comments View in context: https://bugs.webkit.org/attachment.cgi?id=76529&action=review > WebCore/inspector/Inspector.idl:132 > +#if defined(ENABLE_OFFLINE_WEB_APPLICATIONS) && ENABLE_OFFLINE_WEB_APPLICATIONS > + [notify, domain=Resources] void updateApplicationCacheStatus(out int status); > + [notify, domain=Resources] void updateNetworkState(out boolean isNowOnline); > +#endif > +#if defined(ENABLE_OFFLINE_WEB_APPLICATIONS) && ENABLE_OFFLINE_WEB_APPLICATIONS > + [domain=ApplicationCache] void getApplicationCaches(out Value applicationCaches); > +#endif These can just be wrapped in one #if, since they are the same.
mikayla
Comment 19 2019-10-22 03:57:34 PDT Comment hidden (spam)
Note You need to log in before you can comment on or make changes to this bug.