Bug 51025

Summary: Web Inspector: regroup Inspector.idl entries.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, ap, bweinstein, commit-queue, dinhphuong569, jedymark001, joepeck, keishi, kenkoiii001, kihoslohun, loislo, mikayla, mytrinh061995, nagar28496, nodejsquiz, pfeldman, pmuellr, rik, spirulinamanfaat, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 51293    
Attachments:
Description Flags
[patch] first version
none
Inspector.idl
none
[patch] extended version with comments none

Description Ilya Tikhonovsky 2010-12-14 03:58:27 PST 
just for better visibility.
Comment 1 Ilya Tikhonovsky 2010-12-14 04:03:06 PST 
Created attachment 76524 [details]
[patch] first version
Comment 2 Ilya Tikhonovsky 2010-12-14 04:03:53 PST 
Created attachment 76525 [details]
Inspector.idl
Comment 3 Ilya Tikhonovsky 2010-12-14 06:18:46 PST 
Created attachment 76529 [details]
[patch] extended version with comments
Comment 4 Ilya Tikhonovsky 2010-12-14 06:54:55 PST 
Comment on attachment 76529 [details]
[patch] extended version with comments

Clearing flags on attachment: 76529

Committed r74022: <http://trac.webkit.org/changeset/74022>
Comment 5 Ilya Tikhonovsky 2010-12-14 06:55:06 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Joseph Pecoraro 2010-12-14 09:30:27 PST 
Comment on attachment 76529 [details]
[patch] extended version with comments

View in context: https://bugs.webkit.org/attachment.cgi?id=76529&action=review

> WebCore/inspector/Inspector.idl:132
> +#if defined(ENABLE_OFFLINE_WEB_APPLICATIONS) && ENABLE_OFFLINE_WEB_APPLICATIONS
> +        [notify, domain=Resources] void updateApplicationCacheStatus(out int status);
> +        [notify, domain=Resources] void updateNetworkState(out boolean isNowOnline);
> +#endif
> +#if defined(ENABLE_OFFLINE_WEB_APPLICATIONS) && ENABLE_OFFLINE_WEB_APPLICATIONS
> +        [domain=ApplicationCache] void getApplicationCaches(out Value applicationCaches);
> +#endif

These can just be wrapped in one #if, since they are the same.
Comment 19 mikayla 2019-10-22 03:57:34 PDT Comment hidden (spam)