Summary: | Rebaseline: leading and trailing EOL must occur consistently in expectation files | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Cosmin Truta <ctruta> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bweinstein, commit-queue, eric, ojan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 36983 | ||||||||
Attachments: |
|
Description
Cosmin Truta
2010-12-14 01:14:16 PST
Created attachment 76516 [details] Rebaseline This is in preparation for the submission of the patch to bug 36983. I hope I haven't missed anything. Comment on attachment 76516 [details]
Rebaseline
LGTM.
I'm very glad to see the tools converging. The commit-queue encountered the following flaky tests while processing attachment 76516 [details]: inspector/extensions-api.html bug 51053 (author: caseq@chromium.org) http/tests/security/cross-origin-xsl-BLOCKED.html bug 51054 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 76516 [details]: http/tests/security/cross-origin-xsl-BLOCKED.html bug 51054 (author: abarth@webkit.org) fast/events/platform-wheelevent-in-scrolling-div.html bug 51056 (author: aestes@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 76516 [details] Rebaseline Rejecting attachment 76516 [details] from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2 Last 500 characters of output: ........... http/tests/multipart ..... http/tests/navigation ............................................................................................ http/tests/plugins ........ http/tests/security ................................................. http/tests/security/cross-origin-xsl-BLOCKED.html -> failed Exiting early after 1 failures. 21602 tests run. 491.60s total testing time 21601 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 13 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/7110004 Created attachment 76605 [details]
Rebaseline
Resubmitting, with cross-origin-xsl-BLOCKED-expected.txt modified for Chromium only.
Apparently, the chromium test runs leave an extra blank line at the end, compared to all the other non-chromium webkit runs.
Comment on attachment 76605 [details]
Rebaseline
Thanks for doing this. If this one fails, you might consider landing this is pieces. I'm happy to rs=me any of these.
Thank you for assisting me with this, Eric. It's been a headache so far, but I'm sure it's well worth it. Comment on attachment 76605 [details] Rebaseline Clearing flags on attachment: 76605 Committed r74097: <http://trac.webkit.org/changeset/74097> All reviewed patches have been landed. Closing bug. This broke plugins/document-open.html on Windows. Failure: http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r74131%20(7469)/plugins/document-open-pretty-diff.html Opened bug 51147 to add some missing expectation files. |