Bug 51011

Summary: WebKit2: Need to be able to set the application name for the user agent for a WKPage
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch andersca: review+

Sam Weinig
Reported 2010-12-13 21:33:51 PST
We need to be able to set the application name for the user agent for a WKPage.
Attachments
Patch (28.76 KB, patch)
2010-12-13 21:40 PST, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-12-13 21:40:03 PST
Created attachment 76496 [details] Patch
Anders Carlsson
Comment 2 2010-12-13 21:45:43 PST
Comment on attachment 76496 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76496&action=review Maybe we should move the user agent computation code to WebCore so that it can be shared between WebKit1 and WebKit2? > WebKit2/UIProcess/WebPageProxy.cpp:631 > + return; Doesn't seem like this check is needed here. > WebKit2/UIProcess/WebPageProxy.h:404 > + static String standardUserAgent(const String& = String()); I think leaving out the parameter name here just leads to confusion.
Sam Weinig
Comment 3 2010-12-13 21:49:33 PST
Landed in r74000.
Note You need to log in before you can comment on or make changes to this bug.