Summary: | WebKit2: Need to be able to set the application name for the user agent for a WKPage | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Sam Weinig
2010-12-13 21:33:51 PST
Created attachment 76496 [details]
Patch
Comment on attachment 76496 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76496&action=review Maybe we should move the user agent computation code to WebCore so that it can be shared between WebKit1 and WebKit2? > WebKit2/UIProcess/WebPageProxy.cpp:631 > + return; Doesn't seem like this check is needed here. > WebKit2/UIProcess/WebPageProxy.h:404 > + static String standardUserAgent(const String& = String()); I think leaving out the parameter name here just leads to confusion. |