Bug 50965

Summary: [v8] Next round of CSS GC story: proper grouping of CSSStyleDeclarations
Product: WebKit Reporter: anton muhin <antonm>
Component: New BugsAssignee: anton muhin <antonm>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

anton muhin
Reported 2010-12-13 13:35:48 PST
[v8] Next round of CSS GC story: proper grouping of CSSStyleDeclarations
Attachments
Patch (4.62 KB, patch)
2010-12-13 14:31 PST, anton muhin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
anton muhin
Comment 1 2010-12-13 14:31:48 PST
Created attachment 76443 [details] Patch
David Levin
Comment 2 2010-12-13 19:40:44 PST
Looks fine, but shouldn't some items be removed from test expectations (for chromium) with this change?
anton muhin
Comment 3 2010-12-14 06:32:29 PST
Call me paranoid, but I'd prefer to land the fix first and then check on canaries it indeed fixes the trouble for all the platforms. Then I am doing a tiny expectations cleanup. But if you think this commits duplication is stupid, just say so and I'll update the patch, of course. And thanks a lot for review! (In reply to comment #2) > Looks fine, but shouldn't some items be removed from test expectations (for chromium) with this change?
WebKit Commit Bot
Comment 4 2010-12-15 02:58:12 PST
Comment on attachment 76443 [details] Patch Clearing flags on attachment: 76443 Committed r74106: <http://trac.webkit.org/changeset/74106>
WebKit Commit Bot
Comment 5 2010-12-15 02:58:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.