Summary: | WebKit2: Web Inspector windows don't have titles | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brian Weinstein <bweinstein> | ||||||||
Component: | WebKit2 | Assignee: | Timothy Hatcher <timothy> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aroben, bweinstein | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Brian Weinstein
2010-12-13 11:10:48 PST
Created attachment 83229 [details]
Proposed Change
Comment on attachment 83229 [details]
Proposed Change
You might want to give the Windows and Qt EWS a chance to chew on this.
Created attachment 83235 [details]
Proposed Change (with Qt and GTK fixed)
Comment on attachment 83235 [details] Proposed Change (with Qt and GTK fixed) View in context: https://bugs.webkit.org/attachment.cgi?id=83235&action=review > Source/WebKit2/UIProcess/gtk/WebInspectorGtk.cpp:55 > +void WebInspectorProxy::platformInspectedURLChanged(const String& urlString) Could remove the urlString name here. > Source/WebKit2/UIProcess/qt/WebInspectorProxyQt.cpp:54 > +void WebInspectorProxy::platformInspectedURLChanged(const String& urlString) And here. > Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:191 > + ::SetWindowText(m_inspectorWindow, title.charactersWithNullTermination()); You should change this to call ::SetWindowTextW, to match other Win32 API usage in WebKit2. (::SetWindowText is just a macro for ::SetWindowTextW, so there's no behavioral difference.) (In reply to comment #5) > (From update of attachment 83235 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=83235&action=review > > > Source/WebKit2/UIProcess/gtk/WebInspectorGtk.cpp:55 > > +void WebInspectorProxy::platformInspectedURLChanged(const String& urlString) > > Could remove the urlString name here. > > > Source/WebKit2/UIProcess/qt/WebInspectorProxyQt.cpp:54 > > +void WebInspectorProxy::platformInspectedURLChanged(const String& urlString) > > And here. > > > Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:191 > > + ::SetWindowText(m_inspectorWindow, title.charactersWithNullTermination()); > > You should change this to call ::SetWindowTextW, to match other Win32 API usage in WebKit2. (::SetWindowText is just a macro for ::SetWindowTextW, so there's no behavioral difference.) All done. Thanks! Created attachment 83237 [details]
Proposed Change (with Adam's feedback)
|