Summary: | Move caret-browsing related layout tests out of platform/gtk | ||
---|---|---|---|
Product: | WebKit | Reporter: | Mario Sanchez Prada <mario> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | mrobinson, tonikitoo, xan.lopez |
Priority: | P2 | Keywords: | Gtk |
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | All | ||
Bug Depends on: | 25533, 50536 | ||
Bug Blocks: |
Description
Mario Sanchez Prada
2010-12-13 10:33:13 PST
Depending on bug 50536 as well, as the patch for it also involves moving a test from platform/gtk to editing/selection. Hence, it would be nice we wouldn't be proposing a patch for this one until that one gets integrated too, to avoid conflicts. Btw, I wonder whether that could mean that perhaps it's better to move the patches to editing/selection instead of editing/caret-browsing, as proposed in this bug's description. IMHO, I think it's better to create a editing/caret-browsing directory to differentiate tests that are just checking the caret position in certain situations (those usually under editing/selection/*caret*html) from those testing caret navigation in caret browsing mode, which is what this bug is actually about. Opinions? (In reply to comment #0) >[...] > As there's currently a couple of patches pending on review which would add these kind of tests under platform/gtk (see bug 27048 and bug 25533), [...] My mistake, sorry. bug 27048 shouldn't be blocking this one since it provides an GTK-specific accessibility layout test (even if it's related with caretbrowsing). Removing from the list of dependencies. Sorry for the hassle. I need to get more quality sleep time... it was bug 25533 what this one should be blocking, not 25333 :/
> Opinions?
I like editing/caret-browsing
|