Bug 50915

Summary: [GTK] Do not use GET_PRIVATE macros
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch to remove GET_PRIVATE macros none

Carlos Garcia Campos
Reported 2010-12-13 04:39:55 PST
GET_PRIVATE macros are slow and should only be used in the object init() method. We are currently using a pointer to the private structure in the instance structure so we don't need to call GET_PRIVATE. There are only a few places where GET_PRIVATE macros are used, but since they are confusing and useless (it's macro for something that it's going to be used only once), I think we can just remove them all to make sure they are not used anymore.
Attachments
Patch to remove GET_PRIVATE macros (29.46 KB, patch)
2010-12-13 04:42 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2010-12-13 04:42:39 PST
Created attachment 76370 [details] Patch to remove GET_PRIVATE macros
WebKit Commit Bot
Comment 2 2010-12-13 05:27:37 PST
Comment on attachment 76370 [details] Patch to remove GET_PRIVATE macros Clearing flags on attachment: 76370 Committed r73906: <http://trac.webkit.org/changeset/73906>
WebKit Commit Bot
Comment 3 2010-12-13 05:27:41 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 4 2010-12-13 06:17:40 PST
http://trac.webkit.org/changeset/73906 might have broken GTK Linux 64-bit Debug The following tests are not passing: editing/selection/extend-by-character-002.html
Note You need to log in before you can comment on or make changes to this bug.