Bug 50896

Summary: WebKit2: Implement WebInspector::localizedStringsURL on Windows
Product: WebKit Reporter: Brian Weinstein <bweinstein>
Component: Web Inspector (Deprecated)Assignee: Brian Weinstein <bweinstein>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, sam, timothy, yurys
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Fix timothy: review+

Description Brian Weinstein 2010-12-12 12:31:55 PST 
This function needs to be implemented.
Comment 1 Brian Weinstein 2010-12-12 12:32:17 PST 
<rdar://problem/8759907>
Comment 2 Brian Weinstein 2010-12-12 12:37:05 PST 
Created attachment 76332 [details]
[PATCH] Fix
Comment 3 Timothy Hatcher 2010-12-12 12:41:14 PST 
Comment on attachment 76332 [details]
[PATCH] Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=76332&action=review

> WebKit2/WebProcess/WebPage/win/WebInspectorWin.cpp:38
> +    RetainPtr<CFURLRef> htmlURLRef(AdoptCF, CFBundleCopyResourceURL(CFBundleGetBundleWithIdentifier(CFSTR("com.apple.WebKit")), CFSTR("localizedStrings"), CFSTR("js"), 0));
> +    if (!htmlURLRef)

The variable should be localizedStringsURLRef not htmlURLRef.

> WebKit2/WebProcess/WebPage/win/WebInspectorWin.cpp:41
> +    return String(CFURLGetString(htmlURLRef.get()));

Ditto.
Comment 4 Brian Weinstein 2010-12-12 20:39:26 PST 
Comment on attachment 76332 [details]
[PATCH] Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=76332&action=review

>> WebKit2/WebProcess/WebPage/win/WebInspectorWin.cpp:38
>> +    if (!htmlURLRef)
> 
> The variable should be localizedStringsURLRef not htmlURLRef.

Fixed.
Comment 5 Brian Weinstein 2010-12-12 20:42:29 PST 
Landed in r73884.