Bug 50896

Summary: WebKit2: Implement WebInspector::localizedStringsURL on Windows
Product: WebKit Reporter: Brian Weinstein <bweinstein>
Component: Web Inspector (Deprecated)Assignee: Brian Weinstein <bweinstein>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, sam, timothy, yurys
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Fix timothy: review+

Brian Weinstein
Reported 2010-12-12 12:31:55 PST
This function needs to be implemented.
Attachments
[PATCH] Fix (1.53 KB, patch)
2010-12-12 12:37 PST, Brian Weinstein 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brian Weinstein
Comment 1 2010-12-12 12:32:17 PST
<rdar://problem/8759907>
Brian Weinstein
Comment 2 2010-12-12 12:37:05 PST
Created attachment 76332 [details] [PATCH] Fix
Timothy Hatcher
Comment 3 2010-12-12 12:41:14 PST
Comment on attachment 76332 [details] [PATCH] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=76332&action=review > WebKit2/WebProcess/WebPage/win/WebInspectorWin.cpp:38 > + RetainPtr<CFURLRef> htmlURLRef(AdoptCF, CFBundleCopyResourceURL(CFBundleGetBundleWithIdentifier(CFSTR("com.apple.WebKit")), CFSTR("localizedStrings"), CFSTR("js"), 0)); > + if (!htmlURLRef) The variable should be localizedStringsURLRef not htmlURLRef. > WebKit2/WebProcess/WebPage/win/WebInspectorWin.cpp:41 > + return String(CFURLGetString(htmlURLRef.get())); Ditto.
Brian Weinstein
Comment 4 2010-12-12 20:39:26 PST
Comment on attachment 76332 [details] [PATCH] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=76332&action=review >> WebKit2/WebProcess/WebPage/win/WebInspectorWin.cpp:38 >> + if (!htmlURLRef) > > The variable should be localizedStringsURLRef not htmlURLRef. Fixed.
Brian Weinstein
Comment 5 2010-12-12 20:42:29 PST
Landed in r73884.
Note You need to log in before you can comment on or make changes to this bug.