Bug 50844

Summary:

Implement Download::start() and Download::startWithHandle() on WebKit2 (Windows)

Product:

WebKit

Reporter:

Ada Chan <adachan>

Component:

WebKit2

Assignee:

Ada Chan <adachan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, andersca, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
Patch	andersca: review+

Description Ada Chan 2010-12-10 14:24:13 PST

Implement Download::start() and Download::startWithHandle() on WebKit2 on Windows.

Comment 1 Ada Chan 2010-12-10 14:37:06 PST

Created attachment 76264 [details]
Patch

Comment 2 Anders Carlsson 2010-12-10 14:41:30 PST

Comment on attachment 76264 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76264&action=review

> WebKit2/WebProcess/Downloads/cf/DownloadCFNet.cpp:122
> +    CFRetain(request);

Please add a comment here - "CFNetwork requires us to return a retained request" or something.

> WebKit2/WebProcess/Downloads/cf/DownloadCFNet.cpp:158
> +    if (!destination.isNull()) {

Could just do an early return here.

Comment 3 Ada Chan 2010-12-10 15:00:37 PST

Thanks Anders!

I have addressed your feedback and checked in: http://trac.webkit.org/changeset/73807

Comment 4 WebKit Review Bot 2010-12-10 15:17:39 PST

http://trac.webkit.org/changeset/73807 might have broken SnowLeopard Intel Release (Build)