Bug 50844

Summary: Implement Download::start() and Download::startWithHandle() on WebKit2 (Windows)
Product: WebKit Reporter: Ada Chan <adachan>
Component: WebKit2Assignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, andersca, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch andersca: review+

Ada Chan
Reported 2010-12-10 14:24:13 PST
Implement Download::start() and Download::startWithHandle() on WebKit2 on Windows.
Attachments
Patch (9.63 KB, patch)
2010-12-10 14:37 PST, Ada Chan 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2010-12-10 14:37:06 PST
Created attachment 76264 [details] Patch
Anders Carlsson
Comment 2 2010-12-10 14:41:30 PST
Comment on attachment 76264 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76264&action=review > WebKit2/WebProcess/Downloads/cf/DownloadCFNet.cpp:122 > + CFRetain(request); Please add a comment here - "CFNetwork requires us to return a retained request" or something. > WebKit2/WebProcess/Downloads/cf/DownloadCFNet.cpp:158 > + if (!destination.isNull()) { Could just do an early return here.
Ada Chan
Comment 3 2010-12-10 15:00:37 PST
Thanks Anders! I have addressed your feedback and checked in: http://trac.webkit.org/changeset/73807
WebKit Review Bot
Comment 4 2010-12-10 15:17:39 PST
http://trac.webkit.org/changeset/73807 might have broken SnowLeopard Intel Release (Build)
Note You need to log in before you can comment on or make changes to this bug.