Bug 50842

Summary:

Shader::loadShader() must initialize variable passed to getShaderiv

Product:

WebKit

Reporter:

Vincent Scheib <scheib>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jamesr, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Description Vincent Scheib 2010-12-10 13:56:24 PST

Shader::loadShader() must initialize variable passed to getShaderiv

Comment 1 Vincent Scheib 2010-12-10 13:57:41 PST

Created attachment 76254 [details]
Patch

Comment 2 Vincent Scheib 2010-12-10 14:01:08 PST

Looks like recent additions of debug check logic are now warning us of uninitialized variables passed to getter functions. 

E.g. this output on a debug build:
gpu/command_buffer/client/../client/gles2_c_lib_autogen.h(369): GPU_DCHECK(params && (params[0] == static_cast<GLint>(0) || params[0] == static_cast<GLint>(-1)) (0)) failed.

Comment 3 James Robinson 2010-12-10 14:02:55 PST

Comment on attachment 76254 [details]
Patch

Good catch!  R=me

Comment 4 WebKit Review Bot 2010-12-10 19:00:56 PST

Comment on attachment 76254 [details]
Patch

Clearing flags on attachment: 76254

Committed r73832: <http://trac.webkit.org/changeset/73832>

Comment 5 WebKit Review Bot 2010-12-10 19:01:01 PST

All reviewed patches have been landed.  Closing bug.