Bug 50830

Summary: Use FileSystem::remove when cleaning up http lock files
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch eric: review+

Tony Chang
Reported 2010-12-10 10:43:31 PST
Use FileSystem::remove when cleaning up http lock files
Attachments
Patch (3.33 KB, patch)
2010-12-10 10:46 PST, Tony Chang 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-12-10 10:46:01 PST
Created attachment 76220 [details] Patch
Tony Chang
Comment 2 2010-12-10 10:47:24 PST
Here's a more precise description of the problem we were seeing on Windows: When a process is killed, Windows may hold on to the files for a short time after the process has ended. It reminds me of how tcp ports may still be used for a short while after the process using them has been killed.
Tony Chang
Comment 3 2010-12-10 10:48:13 PST
(In reply to comment #2) > Here's a more precise description of the problem we were seeing on Windows: > > When a process is killed, Windows may hold on to the files for a short time after the process has ended. It reminds me of how tcp ports may still be used for a short while after the process using them has been killed. Oh, so it's not clear that we want to apply FileSystem.remove everywhere, but I guess it would be harmless to do so. Maybe we should rename it to something more specific for this specific case?
Eric Seidel (no email)
Comment 4 2010-12-10 12:18:16 PST
Generally using Filesysem function is better than os. because they're more easily mockable.
Eric Seidel (no email)
Comment 5 2010-12-10 12:18:43 PST
Comment on attachment 76220 [details] Patch OK.
Tony Chang
Comment 6 2010-12-10 12:23:32 PST
Committed r73769: <http://trac.webkit.org/changeset/73769>
Note You need to log in before you can comment on or make changes to this bug.