Bug 50818

Summary: Use enums instead of booleans in ImageSource/ImageDecoder constructors
Product: WebKit Reporter: Zhenyao Mo <zmo>
Component: ImagesAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dglazkov, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch abarth: review+, commit-queue: commit-queue-

Zhenyao Mo
Reported 2010-12-10 08:10:10 PST
As Adam called it, it's my debt. Paying it now...
Attachments
Patch (24.61 KB, patch)
2010-12-10 08:23 PST, Zhenyao Mo 		no flags
DetailsFormatted DiffDiff
Patch (24.61 KB, patch)
2010-12-10 08:56 PST, Zhenyao Mo 		abarth: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2010-12-10 08:23:01 PST
Created attachment 76203 [details] Patch
WebKit Review Bot
Comment 2 2010-12-10 08:48:47 PST
Attachment 76203 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7000031
Zhenyao Mo
Comment 3 2010-12-10 08:56:24 PST
Created attachment 76208 [details] Patch
Adam Barth
Comment 4 2010-12-10 13:15:37 PST
Comment on attachment 76208 [details] Patch Thanks. I appreciate it.
WebKit Commit Bot
Comment 5 2010-12-10 17:07:53 PST
Comment on attachment 76208 [details] Patch Rejecting attachment 76208 [details] from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/JSGeolocationCustom.o /Projects/CommitQueue/WebCore/bindings/js/JSGeolocationCustom.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/JSHashChangeEvent.o /Projects/CommitQueue/WebKitBuild/Debug/DerivedSources/WebCore/JSHashChangeEvent.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (215 failures) Full output: http://queues.webkit.org/results/6909038
Zhenyao Mo
Comment 6 2010-12-10 17:19:46 PST
Committed r73819: <http://trac.webkit.org/changeset/73819>
Note You need to log in before you can comment on or make changes to this bug.