Summary: | Refactor by merging tests for ValidityState (patternMismatch and customError) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dai Mikurube <dmikurube> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, commit-queue, eric, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 50617 | ||||||
Attachments: |
|
Description
Dai Mikurube
2010-12-09 23:17:22 PST
Created attachment 76167 [details]
Patch
Comment on attachment 76167 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76167&action=review ok. > LayoutTests/fast/forms/ValidityState-patternMismatch-expected.txt:6 > +PASS patternMismatchFor("simple") is false The result readability is better than the original. It would be much better if pattern and value are printed. Comment on attachment 76167 [details] Patch Rejecting attachment 76167 [details] from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--non-interactive', 76167]" exit_code: 2 Last 500 characters of output: led to merge in the changes. Patch failed at 0001 [Qt] Make sure we send the response before any data. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at WebKitTools/Scripts/update-webkit line 132. Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Full output: http://queues.webkit.org/results/6989034 Adam's start-commit-queue.sh wrapper script was missing a git rebase --abort call, so I added it. Sorry for the noise. Comment on attachment 76167 [details] Patch Clearing flags on attachment: 76167 Committed r73715: <http://trac.webkit.org/changeset/73715> All reviewed patches have been landed. Closing bug. |