Bug 50766

Summary: commit-queue errors out due to local commits
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, ojan, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 49798    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Adam Barth 2010-12-09 09:55:50 PST
commit-queue errors out due to local commits
Comment 1 Adam Barth 2010-12-09 09:59:33 PST
Created attachment 76079 [details]
Patch
Comment 2 Ojan Vafai 2010-12-09 10:33:49 PST
Comment on attachment 76079 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76079&action=review

Seems fine. I don't see how this will fix anything given that we do the same thing in apply, but I don't see harm in making this change. cq- cause of the typos.

> WebKitTools/Scripts/webkitpy/tool/bot/commitqueuetask.py:88
> +        "Unable to clearn working directory")

typo: clearn
Comment 3 Eric Seidel (no email) 2010-12-09 10:45:00 PST
I think this is a good idea.
Comment 4 Adam Barth 2010-12-09 10:49:36 PST
Created attachment 76093 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2010-12-09 20:53:33 PST
Comment on attachment 76093 [details]
Patch for landing

Clearing flags on attachment: 76093

Committed r73682: <http://trac.webkit.org/changeset/73682>
Comment 6 WebKit Commit Bot 2010-12-09 20:53:39 PST
All reviewed patches have been landed.  Closing bug.