RESOLVED FIXED 50766
commit-queue errors out due to local commits 
https://bugs.webkit.org/show_bug.cgi?id=50766
Summary commit-queue errors out due to local commits
Adam Barth
Reported 2010-12-09 09:55:50 PST
commit-queue errors out due to local commits
Attachments
Patch (13.49 KB, patch)
2010-12-09 09:59 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.49 KB, patch)
2010-12-09 10:49 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-12-09 09:59:33 PST
Created attachment 76079 [details] Patch
Ojan Vafai
Comment 2 2010-12-09 10:33:49 PST
Comment on attachment 76079 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76079&action=review Seems fine. I don't see how this will fix anything given that we do the same thing in apply, but I don't see harm in making this change. cq- cause of the typos. > WebKitTools/Scripts/webkitpy/tool/bot/commitqueuetask.py:88 > + "Unable to clearn working directory") typo: clearn
Eric Seidel (no email)
Comment 3 2010-12-09 10:45:00 PST
I think this is a good idea.
Adam Barth
Comment 4 2010-12-09 10:49:36 PST
Created attachment 76093 [details] Patch for landing
WebKit Commit Bot
Comment 5 2010-12-09 20:53:33 PST
Comment on attachment 76093 [details] Patch for landing Clearing flags on attachment: 76093 Committed r73682: <http://trac.webkit.org/changeset/73682>
WebKit Commit Bot
Comment 6 2010-12-09 20:53:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.