Bug 50741

Summary: [GTK] configure: error out if video is enabled and gstreamer pkg-config check fails
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
proposed patch xan.lopez: review+

Philippe Normand
Reported 2010-12-09 02:51:23 PST
In the configure.ac PKG_CHECK_MODULES call for gstreamer the action-if-not-found we have is to set $have_gstreamer to "no". The consequence is that in this case the build will fail. So if HTML5 media is enabled at configure time and if the pkg-config gstreamer check fails the configure script should error out, which is the default action-if-not-found of PKG_CHECK_MODULES.
Attachments
proposed patch (1.32 KB, patch)
2010-12-09 02:55 PST, Philippe Normand 		xan.lopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2010-12-09 02:55:38 PST
Created attachment 76030 [details] proposed patch
Xan Lopez
Comment 2 2010-12-09 03:02:50 PST
Comment on attachment 76030 [details] proposed patch r=me
Philippe Normand
Comment 3 2010-12-09 03:08:59 PST
Committed r73600: <http://trac.webkit.org/changeset/73600>
Note You need to log in before you can comment on or make changes to this bug.